support mariadb (fully compatible with mysql) #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thed0ct0r
changed the title
|
@thed0ct0r, @tomseffect thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having read that coroot now supports mysql i was happy to check it out - to see if i can get some better analysis of some of my databases. i could not get it to work though, the screenshot in the 1.3.0 release notes shows a mariadb database, but i could not get mariadb databases to show up - only mysql ones (see here: 1.3.0 release notes )
having a look at the code, it seemed like if the running process was identifies to be mysqld - a metric would be set which would then indicate the application type. so, adding the mariadbd to the process list to set the mysql label worked perfectly.
since they are protocol (and a lot of code) compatible, all features work fine, including the mysql tab, as well as profiling, io, etc...